5 ➡️ 6 (main)

[chapulina]

➡️ Forward port

Port ign-launch5 to main.

Branch comparison: main...ign-launch5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

[codecov]

Codecov Report

Merging #155 (7136a2d) into main (f40d7a7) will not change coverage.
The diff coverage is n/a.

❗ Current head 7136a2d differs from pull request most recent head 50ed180. Consider uploading reports for the commit 50ed180 to get more accurate results

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   32.92%   32.92%           
=======================================
  Files           4        4           
  Lines         817      817           
=======================================
  Hits          269      269           
  Misses        548      548           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40d7a7...50ed180. Read the comment docs.

[mjcarroll]

I believe windows is expected, but homebrew is giving:

CMake Error at /usr/local/share/cmake/pybind11/pybind11NewTools.cmake:207 (python3_add_library):
  Unknown CMake command "python3_add_library".
Call Stack (most recent call first):
  python/CMakeLists.txt:39 (pybind11_add_module)

[scpeters]

I believe windows is expected, but homebrew is giving:

CMake Error at /usr/local/share/cmake/pybind11/pybind11NewTools.cmake:207 (python3_add_library):
  Unknown CMake command "python3_add_library".
Call Stack (most recent call first):
  python/CMakeLists.txt:39 (pybind11_add_module)

retrying homebrew now that osrf/homebrew-simulation#1870 has been merged

[chapulina]

Homebrew is still unhappy, I don't think that's introduced by this PR though

Fixed