Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkg-config version comparator for Qt #610

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes pkg-config test in gz-gui9 bottle test: Build Status

Summary

The pkg-config test for gz-gui9 bottle fails with:

pkg-config
gz-gui9
--cflags

Package 'gz-gui9' requires 'Qt5Widgets = 5.15' but version of Qt5Widgets is 5.15.12

The fix is to use the >= comparator when finding Qt.

Tested with this branch in Build Status using ci_matching_branch/.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from mjcarroll February 13, 2024 00:08
@scpeters scpeters requested a review from jennuine as a code owner February 13, 2024 00:08
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32773d6) 70.09% compared to head (bcf0378) 70.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   70.09%   70.09%           
=======================================
  Files          38       38           
  Lines        5350     5350           
=======================================
  Hits         3750     3750           
  Misses       1600     1600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scpeters scpeters merged commit 3ca29c6 into main Feb 13, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/fix_qt_ver_pkgconfig branch February 13, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants