Set View Camera controller from plugin configuration

[ahcorde]

Signed-off-by: Alejandro Hernández Cordero [email protected]

🎉 New feature

Summary

Set View Camera controller from plugin configuration

      <!-- 3D scene -->
      <plugin filename="MinimalScene" name="3D View">
        <ignition-gui>
          <title>3D View</title>
          <property type="bool" key="showTitleBar">false</property>
          <property type="string" key="state">docked</property>
        </ignition-gui>

        <engine>ogre2</engine>
        <scene>scene</scene>
        <ambient_light>0.4 0.4 0.4</ambient_light>
        <background_color>0.8 0.8 0.8</background_color>
        <camera_pose>-6 0 6 0 0.5 0</camera_pose>
        <camera_clip>
          <near>0.25</near>
          <far>25000</far>
        </camera_clip>
        <view_controller>ortho</view_controller>
      </plugin>

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #506 (296836f) into ign-gui6 (0e4a198) will increase coverage by 1.25%.
The diff coverage is 100.00%.

❗ Current head 296836f differs from pull request most recent head 4ef3676. Consider uploading reports for the commit 4ef3676 to get more accurate results

@@             Coverage Diff              @@
##           ign-gui6     #506      +/-   ##
============================================
+ Coverage     66.85%   68.10%   +1.25%     
============================================
  Files            39       39              
  Lines          5310     5327      +17     
============================================
+ Hits           3550     3628      +78     
+ Misses         1760     1699      -61     

Impacted Files	Coverage Δ
src/plugins/minimal_scene/MinimalScene.cc	61.17% <100.00%> (+1.17%)	⬆️
...interactive_view_control/InteractiveViewControl.cc	49.48% <0.00%> (+31.44%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[iche033]

looks good to me, just one minor suggestion

[jennuine]

nit (curly braces and remove already):

Suggested change

	if (!_result)
	ignerr << "Error setting view controller. Check if view angle GUI "
	"plugin is already loaded" << std::endl;
	if (!_result)
	{
	ignerr << "Error setting view controller. Check if the View Angle GUI "
	<< "plugin is loaded." << std::endl;
	}

[jennuine]

Don't we always want to set this back to an empty string regardless if _result is true or false? If _result == false, then the request will be sent at each Render() call

[ahcorde]

@jennuine Added feedback here 0f7e805

[jennuine]

Thanks for the updates. I added a test to help with code coverage 4ef3676

Feel free to merge if you're ok with the changes