Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistaken dialog error message #472

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

When closing Gazebo Sim's quick start dialog, you'll currently see an error message like this:

[GUI] [Err] [Dialog.cc:131] Failed to save file: /home/chapulina/.ignition/gazebo/gui.config.
Check file permissions.

Which is mistaken, because the file was in fact correctly chosen. The issue was treating the return value of SaveFile as a boolean instead of checking for the error code. See the SaveFile API.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the bug Something isn't working label Aug 17, 2022
@chapulina chapulina requested a review from jennuine as a code owner August 17, 2022 16:22
@chapulina chapulina enabled auto-merge (squash) August 17, 2022 16:28
@chapulina chapulina merged commit 593c0e0 into ign-gui3 Aug 17, 2022
@chapulina chapulina deleted the chapulina/3/dialog_msg branch August 17, 2022 16:41
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 17, 2022
@chapulina chapulina mentioned this pull request Aug 17, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants