-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for Plugin::ConfigStr() #447
Conversation
Signed-off-by: youhy <[email protected]>
Signed-off-by: youhy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #447 +/- ##
============================================
+ Coverage 67.81% 69.32% +1.50%
============================================
Files 29 29
Lines 3281 3276 -5
============================================
+ Hits 2225 2271 +46
+ Misses 1056 1005 -51
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Signed-off-by: youhy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead and wrap this in LCOV_EXCL_START/STOP
as well:
Lines 365 to 366 in e0acd4a
ignwarn << "There was an error parsing the plugin element for " << | |
"[" << this->title << "]." << std::endl; |
@osrf-jenkins run tests please |
Signed-off-by: youhy [email protected]
New feature
Summary
Add test for
Plugin::ConfigStr()
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.