Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Plugin::ConfigStr() #447

Merged
merged 6 commits into from
Aug 6, 2022
Merged

Conversation

AzulRadio
Copy link
Contributor

Signed-off-by: youhy [email protected]

New feature

Summary

Add test for Plugin::ConfigStr()

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 29, 2022
Signed-off-by: youhy <[email protected]>
@AzulRadio AzulRadio added the tests Broken or missing tests / testing infra label Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #447 (773bfd4) into ign-gui3 (33bbf41) will increase coverage by 1.50%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           ign-gui3     #447      +/-   ##
============================================
+ Coverage     67.81%   69.32%   +1.50%     
============================================
  Files            29       29              
  Lines          3281     3276       -5     
============================================
+ Hits           2225     2271      +46     
+ Misses         1056     1005      -51     
Impacted Files Coverage Δ
src/Plugin.cc 82.68% <ø> (+21.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead and wrap this in LCOV_EXCL_START/STOP as well:

gz-gui/src/Plugin.cc

Lines 365 to 366 in e0acd4a

ignwarn << "There was an error parsing the plugin element for " <<
"[" << this->title << "]." << std::endl;

src/Plugin_TEST.cc Outdated Show resolved Hide resolved
src/Plugin_TEST.cc Outdated Show resolved Hide resolved
src/Plugin_TEST.cc Show resolved Hide resolved
src/Plugin_TEST.cc Outdated Show resolved Hide resolved
src/Plugin_TEST.cc Outdated Show resolved Hide resolved
src/Plugin_TEST.cc Outdated Show resolved Hide resolved
src/Plugin_TEST.cc Outdated Show resolved Hide resolved
@jennuine
Copy link
Contributor

jennuine commented Aug 4, 2022

@osrf-jenkins run tests please

@jennuine jennuine merged commit f59ae67 into ign-gui3 Aug 6, 2022
@jennuine jennuine deleted the azulradio/plugin_test branch August 6, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants