Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Partial Docs Migration and Project Name Followups : gz-gui #425

Merged
merged 8 commits into from
Jun 29, 2022
Merged

ign -> gz Partial Docs Migration and Project Name Followups : gz-gui #425

merged 8 commits into from
Jun 29, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jun 28, 2022
Closed
@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #425 (baef28f) into main (02cb9fd) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
- Coverage   64.07%   64.03%   -0.04%     
==========================================
  Files          45       45              
  Lines        5539     5539              
==========================================
- Hits         3549     3547       -2     
- Misses       1990     1992       +2
Impacted Files Coverage Δ
include/gz/gui/GuiEvents.hh 100.00% <ø> (ø)
src/plugins/camera_tracking/CameraTracking.cc 68.45% <ø> (ø)
src/plugins/grid_config/GridConfig.cc 22.35% <ø> (ø)
src/plugins/grid_config/GridConfig.hh 100.00% <ø> (ø)
src/plugins/minimal_scene/MinimalScene.hh 100.00% <ø> (ø)
src/plugins/minimal_scene/MinimalSceneRhi.hh 100.00% <ø> (ø)
...s/transport_scene_manager/TransportSceneManager.cc 53.97% <ø> (ø)
src/plugins/world_control/WorldControl.cc 77.37% <ø> (ø)
src/plugins/minimal_scene/MinimalScene.cc 65.19% <100.00%> (ø)
src/plugins/scene3d/Scene3D.cc 49.56% <100.00%> (-0.26%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02cb9fd...baef28f. Read the comment docs.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 28, 2022
@methylDragon methylDragon changed the title ign -> gz Partial Docs and Project Name Followups : gz-gui ign -> gz Partial Docs Migration and Project Name Followups : gz-gui Jun 28, 2022
@methylDragon methylDragon force-pushed the docs_and_project_followups branch from 2850e72 to a680327 Compare June 28, 2022 01:14
@methylDragon methylDragon enabled auto-merge (squash) June 28, 2022 05:42
chapulina
chapulina suggested changes Jun 28, 2022
View reviewed changes
doc/qt.tag.xml Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the docs_and_project_followups branch from f8ba64a to 9709535 Compare June 28, 2022 18:56
jennuine
jennuine reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some other docs that may need updating

tutorials/01_install.md Outdated Show resolved Hide resolved
src/plugins/minimal_scene/MinimalScene.hh Outdated Show resolved Hide resolved
src/plugins/scene3d/Scene3D.hh Outdated Show resolved Hide resolved
tutorials/01_install.md Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the docs_and_project_followups branch 2 times, most recently from 758c914 to 837023a Compare June 28, 2022 20:00
methylDragon and others added 8 commits June 28, 2022 15:52
@methylDragon
Migrate some docs and project names in macros
82a543e 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Add project name migration note in Migration.md
b0afd98 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
More aggressively migrate ign-gazebo mentions
d138683 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
More aggressively migrate ign-libX mentions, even for older versions
c32f450 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
More aggressive migrations for ignition- and ign-
febcab8 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate brief Ign-
8d40003 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate warning
2644ec8 
Signed-off-by: methylDragon <[email protected]>
@methylDragon @jennuine
Migrate more docs
baef28f 
Signed-off-by: methylDragon <[email protected]>

Co-authored-by: Jenn Nguyen <[email protected]>
@methylDragon methylDragon force-pushed the docs_and_project_followups branch from 9b5c6b3 to baef28f Compare June 28, 2022 22:53
@methylDragon methylDragon merged commit 05f4bec into main Jun 29, 2022
@methylDragon methylDragon deleted the docs_and_project_followups branch June 29, 2022 01:26
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine jennuine left review comments

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @chapulina @jennuine