Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name and logo on UI, examples and API docs #398

Merged
merged 2 commits into from
May 20, 2022
Merged

Conversation

chapulina
Copy link
Contributor

Summary

  • Logo
  • Window title
  • Example docs
  • API docs
  • Version header
  • CLI message

gz-gui

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo label May 17, 2022
@chapulina chapulina requested a review from methylDragon May 17, 2022 02:31
@chapulina chapulina requested a review from jennuine as a code owner May 17, 2022 02:31
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #398 (8ac8b41) into main (01a0753) will not change coverage.
The diff coverage is n/a.

❗ Current head 8ac8b41 differs from pull request most recent head 96db6c5. Consider uploading reports for the commit 96db6c5 to get more accurate results

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   30.03%   30.03%           
=======================================
  Files          43       43           
  Lines        1888     1888           
=======================================
  Hits          567      567           
  Misses       1321     1321           
Impacted Files Coverage Δ
include/gz/gui/qrc_resources.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a0753...96db6c5. Read the comment docs.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, found a couple more docs in case you want to change in this PR:

include/gz/gui/config.hh.in Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

found a couple more docs in case you want to change in this PR:

Thanks! Updated in 96db6c5

@chapulina chapulina merged commit 9b65b81 into main May 20, 2022
@chapulina chapulina deleted the chapulina/7/gz_ui branch May 20, 2022 00:09
srmainwaring added a commit to srmainwaring/gz-gui that referenced this pull request May 21, 2022
… QML

- Adapt the GammaAdjust element from QtGraphicalEffects to work with Metal
- Add shaders from Qt
- Create a Vulkan supported version of the fragment shader
- Generate a shader pack using qsb
- Refactor gamma adjustment QML
- Move to own QML file and locate with ignition/gui/qml
- Move shaders to a private subfolder
- Update resources.qrc
- Replace import QtGraphicalEffects 1.0 with import "qrc:/qml"

Signed-off-by: Rhys Mainwaring <[email protected]>

Move header files with git mv (gazebosim#395)

Signed-off-by: methylDragon <[email protected]>

Create redirection aliases (gazebosim#395)

Signed-off-by: methylDragon <[email protected]>

Migrate sources in src, test, examples, and include (gazebosim#395)

Signed-off-by: methylDragon <[email protected]>

Migrate CMake files (gazebosim#395)

Signed-off-by: methylDragon <[email protected]>

Update name and logo on UI, examples and API docs (gazebosim#398)

Signed-off-by: Louise Poubel <[email protected]>
srmainwaring added a commit to srmainwaring/gz-gui that referenced this pull request Jun 12, 2022
… QML

- Adapt the GammaAdjust element from QtGraphicalEffects to work with Metal
- Add shaders from Qt
- Create a Vulkan supported version of the fragment shader
- Generate a shader pack using qsb
- Refactor gamma adjustment QML
- Move to own QML file and locate with ignition/gui/qml
- Move shaders to a private subfolder
- Update resources.qrc
- Replace import QtGraphicalEffects 1.0 with import "qrc:/qml"

Signed-off-by: Rhys Mainwaring <[email protected]>

Move header files with git mv (gazebosim#395)

Signed-off-by: methylDragon <[email protected]>

Create redirection aliases (gazebosim#395)

Signed-off-by: methylDragon <[email protected]>

Migrate sources in src, test, examples, and include (gazebosim#395)

Signed-off-by: methylDragon <[email protected]>

Migrate CMake files (gazebosim#395)

Signed-off-by: methylDragon <[email protected]>

Update name and logo on UI, examples and API docs (gazebosim#398)

Signed-off-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants