Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid nullptr access in MinimalScene #380

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

While debugging a problem in ign-rendering, I noticed that we may access a null scene here. So just guard against that.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the bug Something isn't working label Mar 30, 2022
@chapulina chapulina requested a review from jennuine as a code owner March 30, 2022 17:31
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #380 (5fcff84) into ign-gui6 (ec910ed) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##           ign-gui6     #380      +/-   ##
============================================
- Coverage     65.59%   65.57%   -0.02%     
============================================
  Files            39       39              
  Lines          5139     5142       +3     
============================================
+ Hits           3371     3372       +1     
- Misses         1768     1770       +2     
Impacted Files Coverage Δ
src/plugins/minimal_scene/MinimalScene.cc 64.03% <33.33%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec910ed...5fcff84. Read the comment docs.

@chapulina chapulina force-pushed the chapulina/6/null_scene branch from 176401f to 5fcff84 Compare March 30, 2022 18:47
@chapulina chapulina enabled auto-merge (squash) March 30, 2022 19:30
@chapulina chapulina merged commit 32880e2 into ign-gui6 Mar 30, 2022
@chapulina chapulina deleted the chapulina/6/null_scene branch March 30, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants