Added drop event #282
Merged
Added drop event #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 65.20% 65.37% +0.17%
==========================================
Files 32 32
Lines 4532 4604 +72
==========================================
+ Hits 2955 3010 +55
- Misses 1577 1594 +17
Continue to review full report at Codecov.
|
chapulina
approved these changes
Sep 21, 2021
include/ignition/gui/GuiEvents.hh
Outdated
|
|
||
| /// \brief Get the text of the dropped thing on the scene | ||
| /// \return The name of the dropped thing on the scene | ||
| public: const std::string &DropName() const; |
There was a problem hiding this comment.
I think "text" would be more generic than "name", how about using that?
chapulina
approved these changes
Sep 21, 2021
Signed-off-by: ahcorde <[email protected]>
…ics/ign-gui into ahcorde/event/drop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
🎉 Enhacenment
Summary
This event will allow to check something is dropped in the scene3D. This will allow to create independent plugin in ign-gazebo to spawn fuel models or
.stlmodels in the scene.NOTE: This PR is related with the Scene3D consolidation
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge