Removed duplicated code with rendering::sceneFromFirstRenderEngine #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
mjcarroll
added
the
needs upstream release
|
Looks like this will need a release of ign-rendering to pass CI. |
|
@osrf-jenkins retest this please |
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #223 +/- ##
============================================
+ Coverage 59.03% 59.55% +0.52%
============================================
Files 23 23
Lines 2739 2715 -24
============================================
Hits 1617 1617
+ Misses 1122 1098 -24
Continue to review full report at Codecov.
|
|
@mjcarroll the UNIT_Application_TEST is failing buit I think it's unrelated |
|
I think that |
|
In my local machine it's failing here: This should return only one element in the vector, but I'm getting 2. |
|
As this test is unrelated to this PR I will merge it. It seems flaky |
It fails for me there too. I think it probably is flaky |
chapulina
added a commit
that referenced
this pull request
Jun 22, 2021
* Release 3.5.1 (#195) Signed-off-by: Steve Peters <[email protected]> * check_test_ran.py: remove grep/xsltproc (#203) We aren't using QTest anymore in ign-gui, so remove the parts of check_test_ran.py that translated QTest xml files into junit, since they don't work easily on Windows and aren't needed any longer. Fixes #198. Signed-off-by: Steve Peters <[email protected]> * Fixed material specular in scene3D (#218) Signed-off-by: ahcorde <[email protected]> * Remove tools/code_check and update codecov (#222) Signed-off-by: Louise Poubel <[email protected]> * Removed duplicated code with rendering::sceneFromFirstRenderEngine (#223) Signed-off-by: ahcorde <[email protected]> * Emit more events from Scene3D (#213) * Start porting events from ign-gazebo Signed-off-by: Louise Poubel <[email protected]> * Remove test that fails due to #216 Signed-off-by: Louise Poubel <[email protected]> * Move Scene3d_TEST.cc to test/integration There seems to be a problem with loading the ignition-rendering-ogre plugin from the Scene3D test if it links to that plugin. Making Scene3D_TEST.cc into an integration test works because it doesn't directly call any plugin methods. This also changes the linking for the Grid3D plugin to only link to the ignition-rendering core library target instead of the IGNITION-RENDERING_LIBRARIES variable which includes the ogre component library plugins. Signed-off-by: Steve Peters <[email protected]> * process qt events to allow scene to initialize Signed-off-by: Steve Peters <[email protected]> * Add test helper to check event Signed-off-by: Louise Poubel <[email protected]> * added more tests Signed-off-by: ahcorde <[email protected]> * make linters happy Signed-off-by: ahcorde <[email protected]> * Move TestHelper code to .cc file, fix windows? Signed-off-by: Steve Peters <[email protected]> * Fix windows? Signed-off-by: ahcorde <[email protected]> * Fix windows? Signed-off-by: Alejandro Hernández <[email protected]> * Expect values of Vector3 point in click events Signed-off-by: Steve Peters <[email protected]> * Remove debug message Signed-off-by: Steve Peters <[email protected]> * Remove unused variable Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: ahcorde <[email protected]> * Avoid grid3D crash (#227) Signed-off-by: ahcorde <[email protected]> * Confirmation dialog when closing main window (#225) * Adds confirmation dialog when closing window * Updates docs and extends test coverage. * Adds dialog_on_exit atribute to example .config Signed-off-by: Franco Cipollone <[email protected]> * update codeowners (#232) Signed-off-by: Jenn Nguyen <[email protected]> * 🎈 3.6.0 (#233) Signed-off-by: Louise Poubel <[email protected]> * Bump required ign-rendering version to 4.8 (#234) Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Steve Peters <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Franco Cipollone <[email protected]> Co-authored-by: Jenn Nguyen <[email protected]>
|
This PR broke the semantic versioning for Citadel. I was trying to build Citadel with the latest versions of each package, and this yields this error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
Summary
Related to this PR in ignition-renderin gazebosim/gz-rendering#320 (comment). It uses the helper function rendering::sceneFromFirstRenderEngine to get the first scene that can be found in any rendering engine.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge