-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👩🌾 Disable more tests known to fail on macOS and Windows #112
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gui2 #112 +/- ##
=========================================
Coverage 60.43% 60.43%
=========================================
Files 16 16
Lines 2108 2108
=========================================
Hits 1274 1274
Misses 834 834
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, CI is happy and local codecheck passes!
std::unique_ptr
and can be safely ignored because we don't officially support mixing compilers.ign-msgs
andign-rendering
. Once the warnings are handled upstream, we should remove the pragmas from here.