Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👩‍🌾 Disable more tests known to fail on macOS and Windows #112

Merged
merged 6 commits into from
Aug 22, 2020

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 20, 2020

  • Disabled several C4251 warnings about exposing dll interfaces. There are triggered by stl types like std::unique_ptr and can be safely ignored because we don't officially support mixing compilers.
  • Disabled warnings coming from ign-msgs and ign-rendering. Once the warnings are handled upstream, we should remove the pragmas from here.
  • Disabled tests that are known to fail, and are documented on Re-enable skipped tests for OSX and Windows #75
  • Actually fixed some compiler warnings

@chapulina chapulina added tests Broken or missing tests / testing infra Windows Windows support macOS macOS support labels Aug 20, 2020
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #112 into ign-gui2 will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui2     #112   +/-   ##
=========================================
  Coverage     60.43%   60.43%           
=========================================
  Files            16       16           
  Lines          2108     2108           
=========================================
  Hits           1274     1274           
  Misses          834      834           
Impacted Files Coverage Δ
include/ignition/gui/Plugin.hh 100.00% <ø> (ø)
src/ign.cc 37.83% <ø> (ø)
src/plugins/publisher/Publisher.cc 32.89% <ø> (ø)
src/plugins/scene3d/Scene3D.cc 12.86% <0.00%> (ø)
src/plugins/topic_echo/TopicEcho.cc 30.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e57b711...176c36e. Read the comment docs.

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Copy link

@JShep1 JShep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI is happy and local codecheck passes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint macOS macOS support tests Broken or missing tests / testing infra Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants