Fix loading lightmaps from gltf / glb meshes #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
ahcorde
requested changes
Aug 30, 2024
Signed-off-by: Ian Chen <[email protected]>
iche033
changed the title
|
Some tests in UNIT_AssimpLoader_TEST on hombrew are failing. I noticed that they are failing in |
ahcorde
approved these changes
Sep 5, 2024
|
Fixed homebrew CI in #634 |
Crola1702
pushed a commit
that referenced
this pull request
Sep 16, 2024
Signed-off-by: Ian Chen <[email protected]>
iche033
added a commit
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Ian Chen <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Fix loading gltf / glb mesh files with lightmaps. Needed by the Ionic demo world.
Currently the lightmap is ignored if there's a combined roughness + metalness texture. This PR fixes the problem by loading the lightmap (ambient occlusion data) from the roughness + metalness texture.
Tested with a few gltf sample models (water bottle, barramundi fish, damaged helmet)
Here are screenshots of the BarramundiFish before (left) and after (right) the change. I removed the albedo map to better visualize the effect of the lightmap:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.