Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing cstdint header to use uint32_t with gcc-13 #528

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

j-rivero
Copy link
Contributor

🦟 Bug fix

Summary

Build fails in Debian Sid with gcc-13:

In file included from /home/jrivero/code/debian/ignition-common/profiler/src/RemoteryProfilerImpl.hh:26,
                 from /home/jrivero/code/debian/ignition-common/profiler/src/RemoteryProfilerImpl.cc:20:
/home/jrivero/code/debian/ignition-common/profiler/src/ProfilerImpl.hh:56:59: error: ‘uint32_t’ has not been declared
   56 |       public: virtual void BeginSample(const char *_name, uint32_t *_hash) = 0;
      |                                                           ^~~~~~~~
/home/jrivero/code/debian/ignition-common/profiler/src/RemoteryProfilerImpl.hh:74:51: error: ‘uint32_t’ has not been declared
   74 |       public: void BeginSample(const char *_name, uint32_t *_hash) final;
      |                                                   ^~~~~~~~
/home/jrivero/code/debian/ignition-common/profiler/src/RemoteryProfilerImpl.cc:226:6: error: no declaration matches ‘void ignition::common::RemoteryProfilerImpl::BeginSample(const char*, uint32_t*)’
  226 | void RemoteryProfilerImpl::BeginSample(const char *_name, uint32_t *_hash)
      |      ^~~~~~~~~~~~~~~~~~~~
/home/jrivero/code/debian/ignition-common/profiler/src/RemoteryProfilerImpl.hh:74:20: note: candidate is: ‘virtual void ignition::common::RemoteryProfilerImpl::BeginSample(const char*, int*)’
   74 |       public: void BeginSample(const char *_name, uint32_t *_hash) final;
      |                    ^~~~~~~~~~~
/home/jrivero/code/debian/ignition-common/profiler/src/RemoteryProfilerImpl.hh:47:11: note: ‘class ignition::common::RemoteryProfilerImpl’ defined here
   47 |     class RemoteryProfilerImpl: public ProfilerImpl
      |           ^~~~~~~~~~~~~~~~~~~~
make[3]: *** [profiler/src/CMakeFiles/ignition-common4-profiler.dir/build.make:107: profiler/src/CMakeFiles/ignition-common4-profiler.dir/RemoteryProfilerImpl.cc.o] Error 1
make[3]: Leaving directory '/home/jrivero/code/debian/ignition-common/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:3257: profiler/src/CMakeFiles/ignition-common4-profiler.dir/all] Error 2
make[2]: Leaving directory '/home/jrivero/code/debian/ignition-common/obj-x86_64-linux-gnu'

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@j-rivero j-rivero requested a review from marcoag as a code owner August 10, 2023 13:40
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 10, 2023
@j-rivero
Copy link
Contributor Author

One warning in brew unrelated to this commit, as far as I can say. Merging.

@j-rivero j-rivero merged commit 1243852 into ign-common4 Aug 10, 2023
@j-rivero j-rivero deleted the jrivero/use_cstdint branch August 10, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants