Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build examples from CMake rather than executable #502

Merged
merged 12 commits into from
Aug 28, 2023
Merged

Build examples from CMake rather than executable #502

merged 12 commits into from
Aug 28, 2023

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Summary

Part of gazebosim/gz-cmake#301

Test by building gz-common as normal and then running the "EXAMPLES_Configure_TEST" and "EXAMPLES_Build_TEST" via ctest.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll requested a review from marcoag as a code owner April 11, 2023 23:19
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Apr 11, 2023
@azeey azeey self-requested a review April 17, 2023 15:18
@mjcarroll
Reduce function args
1631a03 
Signed-off-by: Michael Carroll <[email protected]>
iche033
iche033 reviewed Apr 28, 2023
View reviewed changes
examples/CMakeLists.txt Outdated Show resolved Hide resolved
ahcorde
ahcorde requested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gz_build_examples is not available. @mjcarroll do you need a gz-cmake release?

@mjcarroll mjcarroll added the needs upstream release Blocked by a release of an upstream library label May 19, 2023
@mjcarroll mjcarroll mentioned this pull request May 19, 2023
Merged
5 tasks
@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

@mjcarroll mjcarroll removed the needs upstream release Blocked by a release of an upstream library label May 23, 2023
@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

@codecov
Copy link

codecov bot commented May 31, 2023 •
edited
Loading

Codecov Report

Merging #502 (964ec56) into gz-common5 (83f8758) will not change coverage.
The diff coverage is n/a.

❗ Current head 964ec56 differs from pull request most recent head e1dabf4. Consider uploading reports for the commit e1dabf4 to get more accurate results

@@             Coverage Diff             @@
##           gz-common5     #502   +/-   ##
===========================================
  Coverage       83.65%   83.65%           
===========================================
  Files              90       90           
  Lines           10249    10249           
===========================================
  Hits             8574     8574           
  Misses           1675     1675

ahcorde
ahcorde requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS is faling

@mjcarroll
Copy link
Contributor Author

macOS is faling

Addressed in #524

@mjcarroll mjcarroll requested review from ahcorde and iche033 July 17, 2023 21:43
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@iche033
Copy link
Contributor

iche033 commented Aug 24, 2023

macOS builds are failing to find gz-common5 when building examples. Is that expected?

@mjcarroll
Copy link
Contributor Author

macOS builds are failing to find gz-common5 when building examples. Is that expected?

We either need to run make install before make test or skip the examples. I would vote for the former as it exercises the examples.

@mjcarroll
Make install before make test
e1dabf4 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll merged commit 6e2444f into gz-common5 Aug 28, 2023
@mjcarroll mjcarroll deleted the mjcarroll/examples_from_cmake branch August 28, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@marcoag marcoag Awaiting requested review from marcoag marcoag is a code owner

@azeey azeey Awaiting requested review from azeey

@iche033 iche033 Awaiting requested review from iche033

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjcarroll @iche033 @ahcorde @azeey