Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename COPYING to LICENSE #494

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Rename COPYING to LICENSE #494

merged 1 commit into from
Mar 14, 2023

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes automatic detection of license type. Similar to gazebosim/gz-math#521.

Summary

The LICENSE file contained a copy of the stanze
used at the top of source code files, while the
actual license was in the COPYING file. So remove
the stanza and put the actual Apache 2.0 license text in LICENSE.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The LICENSE file contained a copy of the stanze
used at the top of source code files, while the
actual license was in the COPYING file. So remove
the stanza and put the actual Apache 2.0 license text
in LICENSE.

Similar to gazebosim/gz-math#521.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from marcoag as a code owner March 14, 2023 01:45
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #494 (6c82414) into ign-common3 (0b54b8c) will not change coverage.
The diff coverage is n/a.

❗ Current head 6c82414 differs from pull request most recent head 1c18544. Consider uploading reports for the commit 1c18544 to get more accurate results

@@             Coverage Diff              @@
##           ign-common3     #494   +/-   ##
============================================
  Coverage        82.66%   82.66%           
============================================
  Files               72       72           
  Lines             9244     9244           
============================================
  Hits              7642     7642           
  Misses            1602     1602           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll
Copy link
Contributor

We discussed windows_nuc possibly having some issues today. Since these are time-based tests, we can assume they are flaky and merge.

@mjcarroll mjcarroll merged commit 6412cd3 into ign-common3 Mar 14, 2023
@mjcarroll mjcarroll deleted the scpeters/license_3 branch March 14, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants