-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress a bunch of unnecessary test output #442
Conversation
This floods the logs without providing any meaningful value or insights Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-common5 #442 +/- ##
==============================================
+ Coverage 80.45% 80.48% +0.03%
==============================================
Files 85 87 +2
Lines 10004 10061 +57
==============================================
+ Hits 8049 8098 +49
- Misses 1955 1963 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Looks like you aren't supposed to use the |
Signed-off-by: Michael Carroll <[email protected]>
…ebosim/gz-common into mjcarroll/suppress_test_output
Signed-off-by: Michael Carroll <[email protected]>
@osrf-jenkins retest this please |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Windows failures are the known GDAL problems. |
🦟 Bug fix
Summary
This test floods the logs without providing any meaningful value or insights. It makes looking at jenkins or actions results more troublesome than necessary. This redirects the output to another buffer.
It doesn't seem to have any impact on the timing results, either:
Before:
After:
Signed-off-by: Michael Carroll [email protected]
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.