Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FindSharedLibrary for relative plugin paths #382

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jun 27, 2022

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

If you are running gazebo in the same folder that a custom plugin is located, then you are able to find it. According with the comment I think this code is more appropriate.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from methylDragon June 27, 2022 22:53
@ahcorde ahcorde requested a review from mjcarroll as a code owner June 27, 2022 22:53
@ahcorde ahcorde self-assigned this Jun 27, 2022
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #382 (4570d80) into ign-common3 (eda17f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           ign-common3     #382   +/-   ##
============================================
  Coverage        76.63%   76.63%           
============================================
  Files               73       73           
  Lines            10424    10425    +1     
============================================
+ Hits              7988     7989    +1     
  Misses            2436     2436           
Impacted Files Coverage Δ
src/SystemPaths.cc 88.08% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda17f5...4570d80. Read the comment docs.

@mjcarroll mjcarroll merged commit cff1858 into ign-common3 Jun 28, 2022
@mjcarroll mjcarroll deleted the ahcorde/fix/findsharedlibrary branch June 28, 2022 01:20
luca-della-vedova pushed a commit that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants