Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup long-deprecated ifdefs #329

Merged
merged 26 commits into from
Aug 31, 2022
Merged

Cleanup long-deprecated ifdefs #329

merged 26 commits into from
Aug 31, 2022

Conversation

mjcarroll
Copy link
Contributor

Removes a good bit of code on the unused side of the LIBAV ifdefs.

All target platforms should be sufficiently beyond ffmpeg 3.1 which allows for this deprecation to take place.

@chapulina chapulina added the AV AV component label Mar 21, 2022
Base automatically changed from ports/4_to_5 to main March 22, 2022 18:09
@mjcarroll mjcarroll marked this pull request as draft March 29, 2022 12:35
@mjcarroll mjcarroll self-assigned this Apr 5, 2022
@mjcarroll mjcarroll force-pushed the av_component_cleanup branch from 0d49785 to fd17965 Compare April 14, 2022 19:46
@chapulina chapulina added the 🌱 garden Ignition Garden label Jun 21, 2022
@chapulina chapulina added Breaking change Breaks API, ABI or behavior. Must target unstable version. bug Something isn't working labels Jul 25, 2022
@chapulina chapulina changed the base branch from main to gz-common5 August 5, 2022 19:06
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #329 (fceb04a) into gz-common5 (629a9be) will decrease coverage by 0.25%.
The diff coverage is 58.06%.

@@              Coverage Diff               @@
##           gz-common5     #329      +/-   ##
==============================================
- Coverage       80.56%   80.31%   -0.26%     
==============================================
  Files              85       85              
  Lines            9956     9987      +31     
==============================================
  Hits             8021     8021              
- Misses           1935     1966      +31     
Impacted Files Coverage Δ
av/include/gz/common/ffmpeg_inc.hh 0.00% <ø> (ø)
av/src/ffmpeg_inc.cc 0.00% <ø> (-65.00%) ⬇️
av/src/VideoEncoder.cc 73.68% <7.69%> (-1.79%) ⬇️
av/src/Video.cc 78.26% <93.33%> (+1.27%) ⬆️
av/src/AudioDecoder.cc 77.47% <100.00%> (-5.86%) ⬇️
av/src/Util.cc 82.75% <0.00%> (+0.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll marked this pull request as ready for review August 31, 2022 16:43
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some trivial comments

av/src/VideoEncoder.cc Outdated Show resolved Hide resolved
av/src/VideoEncoder.cc Outdated Show resolved Hide resolved
av/src/VideoEncoder.cc Outdated Show resolved Hide resolved
mjcarroll and others added 2 commits August 31, 2022 12:48
Signed-off-by: Michael Carroll <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AV AV component Breaking change Breaks API, ABI or behavior. Must target unstable version. bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants