Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out-of-bound access in URI #304

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Fix out-of-bound access in URI #304

merged 1 commit into from
Feb 1, 2022

Conversation

mjcarroll
Copy link
Contributor

Uncovered in the process of testing #301.

Before this fix:

  • Expected behavior: Tests build and run when -D_GLIBCXX_ASSERTIONS is set
  • Actual behavior: Test aborts due to out-of-bounds access

Steps to reproduce

git checkout ign-common4
CXXFLAGS=-D_GLIBCXX_ASSERTIONS cmake -B build -S . -DCMAKE_BUILD_TYPE=Debug
make -C build UNIT_URI_TEST
./build/bin/UNIT_URI_TEST
gdb -ex run ./build/bin/UNIT_URI_TEST

Signed-off-by: Michael Carroll <[email protected]>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Feb 1, 2022
@mjcarroll mjcarroll self-assigned this Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #304 (78cc81b) into ign-common4 (d5261a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common4     #304   +/-   ##
============================================
  Coverage        77.02%   77.02%           
============================================
  Files               76       76           
  Lines            10727    10729    +2     
============================================
+ Hits              8262     8264    +2     
  Misses            2465     2465           
Impacted Files Coverage Δ
src/URI.cc 97.42% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5261a8...78cc81b. Read the comment docs.

@mjcarroll mjcarroll merged commit f22ef93 into ign-common4 Feb 1, 2022
@mjcarroll mjcarroll deleted the out_of_bounds_URI branch February 1, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants