Fix skip logic for integration tests #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check both SKIP_av and INTERNAL_SKIP_av before building integration tests that require av component. Reported in gazebosim#263. Signed-off-by: Steve Peters <[email protected]>
github-actions
bot
added
Gazebo 1️1️
Codecov Report
@@ Coverage Diff @@
## ign-common3 #264 +/- ##
============================================
Coverage 76.55% 76.55%
============================================
Files 73 73
Lines 10386 10386
============================================
Hits 7951 7951
Misses 2435 2435 Continue to review full report at Codecov.
|
chapulina
approved these changes
Oct 28, 2021
mjcarroll
approved these changes
Oct 28, 2021
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes build failure reported in #263 when dependencies for
avcomponent are not available.Summary
Since gazebosim/gz-cmake#165, we need to check both the
SKIP_avandINTERNAL_SKIP_avbefore building integration tests that require theavcomponent. Otherwise the integration tests fail to build, as reported in #263.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge