Disable failing VideoEncoder and Audioecoder tests on Windows

[chapulina]

An attempt at fixing #148.

The test changes are minimal, I recommend the view ignoring whitespace changes:

• Make test verbose
• Create video within a scope, so we can check that it deletes all temp files on destruction
• Output file paths in case the tests fail

The change that I hope will fix it is the use of common::removeFile instead of std::remove.

[codecov]

Codecov Report

Merging #149 (2a1ea60) into ign-common3 (f5550c0) will decrease coverage by 0.01%.
The diff coverage is 55.55%.

@@               Coverage Diff               @@
##           ign-common3     #149      +/-   ##
===============================================
- Coverage        75.87%   75.86%   -0.02%     
===============================================
  Files               69       69              
  Lines             9758     9770      +12     
===============================================
+ Hits              7404     7412       +8     
- Misses            2354     2358       +4     

Impacted Files	Coverage Δ
av/src/VideoEncoder.cc	70.64% <55.55%> (-1.60%)	⬇️
src/Filesystem.cc	80.27% <0.00%> (+2.72%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5550c0...ee631e8. Read the comment docs.

[mjcarroll]

@osrf-jenkins retest this please

[JShep1]

@osrf-jenkins run tests please

[JShep1]

Seems like the test is still failing on Windows, re-running tests for now, and then will look more into it after

[chapulina]

Seems like the test is still failing on Windows

Interesting, it's saying Permission denied when it tries to remove the temp file. Are the permissions of the file created by ffmpeg too strict somehow? Or is there something else happening, like the file being still in use? I don't know... Added more error messages in 93709dd to see if there are more hints.

[chapulina]

Yeah this doesn't fix the issue... For some reason the temp file can't be deleted on Windows... If no one has a good idea for a fix, I suggest we comment out the test on Windows for now

[mjcarroll]

If no one has a good idea for a fix, I suggest we comment out the test on Windows for now

No suggestion on fixing, but I would prefer to use the macro: https://github.com/ignitionrobotics/ign-cmake/blob/ign-cmake2/include/ignition/utilities/ExtraTestMacros.hh#L28

[chapulina]

I would prefer to use the macro

In general I agree, but in this case, the only offending expectations were at the end of the test, so I suggest we just skip those and still run the rest of the test on Windows. See 32421c9

[chapulina]

Also disabled #156

[caguero]

There's a problem on Windows:

C:\Jenkins\workspace\ignition_common-ci-pr_any-windows7-amd64\ws\ign-common\av\src\AudioDecoder_TEST.cc(20): fatal error C1083: Cannot open include file: 'ignition/utilities/ExtraTestMacros.hh': No such file or directory

[chapulina]

There's a problem on Windows:

Ahhh not anymore!