Function to serialize compressed image to buffer

[mjcarroll]

Signed-off-by: Michael Carroll [email protected]

[chapulina]

Mind adding a quick test to check the buffer's contents?

[iche033]

just minor comment on style otherwise looks good to me

just noticed that a test is requested

[codecov]

Codecov Report

Merging #139 (94f837d) into ign-common3 (6a12f59) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head 94f837d differs from pull request most recent head 152d289. Consider uploading reports for the commit 152d289 to get more accurate results

@@               Coverage Diff               @@
##           ign-common3     #139      +/-   ##
===============================================
- Coverage        75.24%   75.16%   -0.08%     
===============================================
  Files               72       72              
  Lines            10227    10237      +10     
===============================================
  Hits              7695     7695              
- Misses            2532     2542      +10     

Impacted Files	Coverage Δ
graphics/src/Image.cc	65.00% <0.00%> (-2.83%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a12f59...152d289. Read the comment docs.

[iche033]

windows build caught a compile error:

C:\Jenkins\workspace\ignition_common-ci-pr_any-windows7-amd64\ws\ign-common\graphics\src\Image.cc(155): error C2664: 'BOOL FreeImage_AcquireMemory(FIMEMORY *,BYTE **,DWORD *)': cannot convert argument 3 from 'unsigned int *' to 'DWORD *'

[nkoenig]

@mjcarroll and @iche033 , CI is now green.

[mjcarroll]

@chapulina there isn't an easy way to test this without implementing the inverse (png buffer to image). Since this is needed by subt, can we land it and I'll add that test in a followup?

[chapulina]

Sure sounds good. I was thinking of a simpler test, maybe just checking the size of the buffer. To make sure that the function is exercised in the tests. But don't block on this.