Add transformation matrix to ColladaExport #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapulina
added
🏰 citadel
iche033
reviewed
Oct 2, 2020
There was a problem hiding this comment.
I was able to export a double pendulum model so I think simple shapes are working. Can you add a test in ColladaExporter_TEST? Something like exporting multiple meshes to a dae file then loading it back with ColladaLoader to make sure they are loaded back as submeshes?
gonzodepedro
force-pushed
the
ign-common3
branch
from
7ae9a63 to
df095ab
Compare
|
@osrf-jenkins run tests |
mjcarroll
reviewed
Oct 23, 2020
Comment on lines
+200
to
+201
| std::string boxFilenameIn = std::string(PROJECT_SOURCE_PATH) + | ||
| "/test/data/box.dae"; |
There was a problem hiding this comment.
Suggested change
| std::string boxFilenameIn = std::string(PROJECT_SOURCE_PATH) + | |
| "/test/data/box.dae"; | |
| std::string boxFilenameIn = common::joinPaths(PROJECT_SOURCE_PATH, | |
| "/test/data/box.dae"); |
There was a problem hiding this comment.
It looks like this went through unresolved partially resolved. The string needs to be separated on all / for Windows.
I also noticed this test failing on CI:
[ RUN ] ColladaExporter.ExportCordlessDrill
unknown file: Failure
C++ exception with description "basic_string::_M_construct null not valid" thrown in the test body.
[ FAILED ] ColladaExporter.ExportCordlessDrill (3 ms)
[ RUN ] ColladaExporter.ExportMeshWithSubmeshes
unknown file: Failure
C++ exception with description "basic_string::_M_construct null not valid" thrown in the test body.
[ FAILED ] ColladaExporter.ExportMeshWithSubmeshes (3 ms)
There was a problem hiding this comment.
Not sure why this didn't fail in the action here?
Fix here: #133
scpeters
reviewed
Oct 23, 2020
gonzodepedro
force-pushed
the
ign-common3
branch
from
0e33ee6 to
2b8d40b
Compare
gonzodepedro
force-pushed
the
ign-common3
branch
from
902c21e to
99ab80f
Compare
mjcarroll
reviewed
Oct 29, 2020
added 10 commits
November 9, 2020 18:01
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
gonzodepedro
force-pushed
the
ign-common3
branch
from
99ab80f to
4809c51
Compare
added 2 commits
November 9, 2020 18:11
Signed-off-by: Gonzalo de Pedro <[email protected]>
Signed-off-by: Gonzalo de Pedro <[email protected]>
mjcarroll
reviewed
Nov 16, 2020
|
mjcarroll
approved these changes
Nov 18, 2020
mjcarroll
added a commit
that referenced
this pull request
Dec 3, 2020
Follow up fix to #100 Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
added a commit
that referenced
this pull request
Dec 3, 2020
Follow up fix to #100 Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gonzalo de Pedro [email protected]
This adds transformation matrixes to nodes con collada files when exporting
Connects to gazebosim/gz-sim#307