Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SuppressWarning.hh with #warning #367

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 18, 2023

🎉 New feature

Closes #348

Summary

The gz/utilities/SuppressWarning.hh header file is redundant with gz/utils/SuppressWarning.hh, so deprecate it.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll
Copy link
Contributor

@scpeters I think this is good to un-draft?

@scpeters
Copy link
Member Author

@scpeters I think this is good to un-draft?

I was hoping to test it before un-drafting it, and I haven't done that yet. I'll try updating one of the examples

@scpeters scpeters force-pushed the scpeters/deprecate_suppress_warning branch from f199935 to 730d764 Compare July 27, 2023 05:31
@scpeters scpeters changed the title Deprecate SuppressWarning.hh with pragma Deprecate SuppressWarning.hh with #warning Jul 27, 2023
@scpeters scpeters marked this pull request as ready for review July 27, 2023 05:32
@scpeters scpeters requested review from mxgrey and j-rivero as code owners July 27, 2023 05:32
@scpeters
Copy link
Member Author

I tested it, and the #pragma wasn't generating a warning, so I switched to #warning, which will either print a compiler warning or fail with a compiler error. Either way it will get attention

@scpeters scpeters merged commit 5a5b77a into main Jul 27, 2023
@scpeters scpeters deleted the scpeters/deprecate_suppress_warning branch July 27, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants