Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify required components in pkg-config #451

Closed
wants to merge 1 commit into from

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Sep 4, 2024

🦟 Bug fix

Fixes #450.

Summary

When a gz-* package is found with find_package, its cmake config file encodes the list of required dependencies in its pkg-config file. If the package is found with required components, those components should be encoded in the pkg-config file as well. This uses the existing for loop over components in the gz-config.cmake.in file and stores the names of required components, then appends them to the string passed to gz_pkg_config_entry.

I spent some time trying to add a test for this in branch scpeters/test_component_export ( gz-cmake4...scpeters/test_component_export ) but have not yet been successful. I've tested this fix manually and think it works.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from azeey September 4, 2024 17:27
@scpeters scpeters requested a review from j-rivero as a code owner September 4, 2024 17:28
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 4, 2024
@scpeters
Copy link
Member Author

scpeters commented Nov 1, 2024

re-open when there is a test

@scpeters scpeters closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

pkg-config does not include required components from dependencies
1 participant