Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix READMEs and Changelogs not rendering on /libs/libname #58

Closed
chapulina opened this issue Aug 13, 2020 · 1 comment
Closed

Fix READMEs and Changelogs not rendering on /libs/libname #58

chapulina opened this issue Aug 13, 2020 · 1 comment
Assignees
Labels
bug Something isn't working infrastructure Requires changes on the web server or other infra

Comments

@chapulina
Copy link
Contributor

I could swear we already had this issue ticketed somewhere but I can't find it now 🤷‍♀️

After migrating to GitHub, our READMEs stopped being rendered on pages like this:

https://ignitionrobotics.org/libs/math

If you check the console, you'll see CORS errors like:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://github.com/ignitionrobotics/ign-math/raw/master/Changelog.md. (Reason: CORS header ‘Access-Control-Allow-Origin’ does not match ‘https://render.githubusercontent.com’).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://github.com/ignitionrobotics/ign-math/raw/master/README.md. (Reason: CORS header ‘Access-Control-Allow-Origin’ does not match ‘https://render.githubusercontent.com’).
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://github.com/ignitionrobotics/ign-math/raw/master/Changelog.md. (Reason: CORS request did not succeed)
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://github.com/ignitionrobotics/ign-math/raw/master/README.md. (Reason: CORS request did not succeed).
@chapulina
Copy link
Contributor Author

@ahcorde bravely fixed this issue on the server side 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure Requires changes on the web server or other infra
Projects
None yet
Development

No branches or pull requests

2 participants