Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to build/install OGRE-2.2 in ignition ws #1

Closed
wants to merge 2 commits into from

Conversation

mjcarroll
Copy link
Collaborator

An attempt to reproduce @j-rivero's Debian packaging in pure CMake.

Uses a colcon.pkg file for compatibility in ignition workspaces

Signed-off-by: Michael Carroll [email protected]

@j-rivero
Copy link

I have nothing against moving packaging code to the build system, has many advantages. The problem I see is that it will make more difficult to sync changes from upstream Ogre sources.

I believe that the PR is inspired by the Bazel, would it be very difficult to maintain the packaging changes there? @iche033 do you have any estimation if we will need to sync this fork to upstream sources in the future?

@mjcarroll
Copy link
Collaborator Author

This was mainly so that I could use the source build of OGRE 2.2 in a colcon workspace, since the debian packaging doesn't translate there. I think once the EGL features all land, the need for having a colcon-compatible repo is less necessary.

This can be dropped in favor of purely doing it in the debian packaging if that's more convenient.

@chapulina
Copy link

@mjcarroll , you mentioned this could be closed. Feel free to do it 👍

@mjcarroll mjcarroll closed this Aug 16, 2021
@mjcarroll mjcarroll deleted the ignition/2-2-packaging branch August 16, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants