Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

1st PR trigger vs 1st PR merged difference #84

Open
polarathene opened this issue Apr 2, 2019 · 4 comments
Open

1st PR trigger vs 1st PR merged difference #84

polarathene opened this issue Apr 2, 2019 · 4 comments
Labels
not stale Tell gatsbot not to close this issue even if there's not activity

Comments

@polarathene
Copy link

I don't know if this affects the store per se. But iirc, @gatsbybot would only add a message to a PR when the author's 1st PR opened was merged, if a PR since then had been added and merged, @gatsbybot did not trigger on that PR instead.

It's a minor issue, although did have me confused as I had started contributing in late December and had a couple PRs accepted before my first one was merged 2 or so months after it was initially opened, which is when I got the invitation for swag at the store(I hadn't checked prior).

@jlengstorf
Copy link
Contributor

@polarathene can you say more about this? It should trigger when your first PR is merged, regardless of other PRs being open.

If that didn’t happen, can you please send links to your PRs so we can dig into this a bit? Thanks!

@polarathene
Copy link
Author

Here are my PRs(filtered by closed which they all are presently).

My first PR submitted to Gatsby is this one,
and this is my first merged PR.

I would have expected the bot to congratulate me on the first PR that was actually merged, not wait until my first submitted PR was merged(which I imagine for some when rejected, they'd never hear from the bot?).

Swag store worked fine though, it had recognized the merged PR prior to the bot congratulating my first submitted PR on being merged.


So just to clarify:

  • Swag store logic works fine once a PR is merged.
  • The bot congratulates once the first submitted PR is merged, not on the first merged PR.

@jlengstorf jlengstorf transferred this issue from gatsbyjs/store.gatsbyjs.org Apr 17, 2019
@jlengstorf
Copy link
Contributor

@gatsbyjs/core @gatsbyjs/ecosystem something is weird here, and I'm not quite sure how this is possible, but apparently Peril is following the first PR, not the first merged PR. 😕

@gatsbot
Copy link

gatsbot bot commented May 8, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@gatsbot gatsbot bot added the stale? label May 8, 2019
@LekoArts LekoArts added not stale Tell gatsbot not to close this issue even if there's not activity and removed stale? labels May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
not stale Tell gatsbot not to close this issue even if there's not activity
Projects
None yet
Development

No branches or pull requests

3 participants