-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for react 0.14 #81
Conversation
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "gatsby", | |||
"description": "React.js Static Site Generator", | |||
"version": "0.6.2", | |||
"version": "0.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend against including version changes in PRs. If this gets superseded by another version update, you'll end up with a merge conflict and it will be harder for the maintainer to merge. Just a heads up! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed :-) the node.js project tags PRs with what kind of release is needed
e.g. semvar-minor which I think is a nice pattern.
On Nov 10, 2015 5:20 PM, "Tim Dorr" [email protected] wrote:
In package.json
#81 (comment):@@ -1,7 +1,7 @@
{
"name": "gatsby",
"description": "React.js Static Site Generator",
- "version": "0.6.2",
- "version": "0.7.0",
I would recommend against including version changes in PRs. If this gets
superseded by another version update, you'll end up with a merge conflict
and it will be harder for the maintainer to merge. Just a heads up! [image:
😄]—
Reply to this email directly or view it on GitHub
https://github.com/gatsbyjs/gatsby/pull/81/files#r44491305.
d781bed
to
809f17c
Compare
@timdorr @KyleAMathews fixed, Thanks for comments 👍 |
What's the status on this? +1 to React v.0.14 support |
I need time to review and merge which won't be until next week. If you'd
|
Add support for react 0.14
@patrykkopycinski thanks!! New release coming soonish. Ensuring everything is working properly. |
No description provided.