Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for react 0.14 #81

Merged
merged 1 commit into from
Nov 21, 2015
Merged

Conversation

patrykkopycinski
Copy link
Contributor

No description provided.

@@ -1,7 +1,7 @@
{
"name": "gatsby",
"description": "React.js Static Site Generator",
"version": "0.6.2",
"version": "0.7.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend against including version changes in PRs. If this gets superseded by another version update, you'll end up with a merge conflict and it will be harder for the maintainer to merge. Just a heads up! 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed :-) the node.js project tags PRs with what kind of release is needed
e.g. semvar-minor which I think is a nice pattern.
On Nov 10, 2015 5:20 PM, "Tim Dorr" [email protected] wrote:

In package.json
#81 (comment):

@@ -1,7 +1,7 @@
{
"name": "gatsby",
"description": "React.js Static Site Generator",

  • "version": "0.6.2",
  • "version": "0.7.0",

I would recommend against including version changes in PRs. If this gets
superseded by another version update, you'll end up with a merge conflict
and it will be harder for the maintainer to merge. Just a heads up! [image:
😄]


Reply to this email directly or view it on GitHub
https://github.com/gatsbyjs/gatsby/pull/81/files#r44491305.

@patrykkopycinski
Copy link
Contributor Author

@timdorr @KyleAMathews fixed, Thanks for comments 👍

@dannyphillips
Copy link

What's the status on this? +1 to React v.0.14 support

@KyleAMathews
Copy link
Contributor

I need time to review and merge which won't be until next week. If you'd
like to merge the branch yourself and test it and report back on how things
are working, that'd be very helpful.
On Thu, Nov 12, 2015 at 6:34 PM Danny Phillips [email protected]
wrote:

What's the status on this? +1 to React v.0.14 support


Reply to this email directly or view it on GitHub
#81 (comment).

KyleAMathews added a commit that referenced this pull request Nov 21, 2015
Add support for react 0.14
@KyleAMathews KyleAMathews merged commit 018fccf into gatsbyjs:master Nov 21, 2015
@KyleAMathews
Copy link
Contributor

@patrykkopycinski thanks!! New release coming soonish. Ensuring everything is working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants