Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable-module-id-hash webpack plugin #559

Merged
merged 3 commits into from
Nov 17, 2016
Merged

Conversation

KyleAMathews
Copy link
Contributor

#533 worked to make module ids stable across builds but added the complication that users needed to checkin the records.json files that Webpack outputs. Which is confusing.

This PR adds https://github.com/zhenyong/webpack-stable-module-id-and-hash which replaces the default incrementing int module ids from Webpack core with 8 digit module ids derived from the hash of each module.

@KyleAMathews KyleAMathews force-pushed the stable-module-id branch 3 times, most recently from 5d16353 to b75c3fb Compare November 17, 2016 04:04
@KyleAMathews
Copy link
Contributor Author

Hmmm... stable-module-id-hash is throwing a collision error on every build on Netlify. Created issue at zhenyong/webpack-stable-module-id-and-hash#8.

In the meantime let's just use the named module plugin which also is deterministic until the above bug is fixed. It's not ideal putting named modules in production as this can leak information but since we're in Alpha no big deal :-) Also going to switch to Webpack 2 soon which has its own hashedmoduleid plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant