feat(gatsby): handle graphql-import-node bundling #36951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: render-mode
pieh
commented
Nov 3, 2022
| @@ -110,6 +110,7 @@ | |||
| "got": "^11.8.5", | |||
| "graphql": "^16.6.0", | |||
| "graphql-compose": "^9.0.9", | |||
| "graphql-tag": "^2.12.6", | |||
There was a problem hiding this comment.
This is already being installed transitively (codegen deps eventually install it), so it's not adding new dependency and just makes sure package managers install it in a way that can be resolved from within gatsby package
pieh
commented
Nov 3, 2022
| @@ -166,6 +166,12 @@ export async function createGraphqlEngineBundle( | |||
| test: /\.txt/, | |||
| type: `asset/resource`, | |||
| }, | |||
| { | |||
| test: /\.(graphqls?|gqls?)$/, | |||
There was a problem hiding this comment.
this is to match const VALID_EXTENSIONS = ['graphql', 'graphqls', 'gql', 'gqls']; from graphql-import-node package, so it doesn't exactly match instructions for loader ( https://www.npmjs.com/package/graphql-tag#webpack-loading-and-preprocessing )
LekoArts
approved these changes
Nov 3, 2022
pieh
added a commit
that referenced
this pull request
Nov 3, 2022
(cherry picked from commit d5c775a)
pieh
added a commit
that referenced
this pull request
Nov 3, 2022
(cherry picked from commit d5c775a) Co-authored-by: Michal Piechowiak <[email protected]>
This was referenced Nov 8, 2022
This was referenced Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds bundling support in case someone is using https://www.npmjs.com/package/graphql-import-node to load queries from
.graphqlfiles from within gatsby-node file.Without this, engine compilation fails as compilation doesn't know how to handle
.graphqlimportsRelated Issues
[ch-56774]