fix(gatsby): prevent escaping textContent for scripts #36174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinjude
added
the
type: bug
gatsbot
bot
added
the
status: triage needed
marvinjude
removed
the
status: triage needed
pieh
reviewed
Jul 19, 2022
LekoArts
added
topic: DX
LekoArts
reviewed
Jul 20, 2022
LekoArts
reviewed
Jul 20, 2022
marvinjude
changed the title
marvinjude
commented
Jul 20, 2022
| ) | ||
| let element | ||
| const attributes = { ...node.attributes, "data-gatsby-head": true } | ||
| if (rawTagName === `script`) { |
There was a problem hiding this comment.
React isn't happy with doing dangerouslySetInnerHTML on <title> so it makes sense to keep this for scripts alone
marvinjude
changed the title
marvinjude
changed the title
pieh
approved these changes
Jul 20, 2022
LekoArts
pushed a commit
that referenced
this pull request
Jul 20, 2022
* prevent escaping textContent for <script> data blocks * fix typo * touch up * spread attributes * add gatsby-head attribute * unescape for all script tags (cherry picked from commit d42243c)
LekoArts
pushed a commit
that referenced
this pull request
Jul 20, 2022
Co-authored-by: Jude Agboola <[email protected]>
|
Fixed in |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent auto escaping of textContent for <script> tags.
See Discussion
Documentation
https://www.gatsbyjs.com/docs/how-to/adding-common-features/adding-seo-component/#rich-snippets
[sc-53448]