test(gatsby-script): Off main thread e2e #35665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
added
type: maintenance
12 tasks
tyhopp
force-pushed
the
test-script-component-off-main-thread-e2e
branch
from
0c6cb16 to
b5a299d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
End-to-end tests for gatsby-script off-main-thread loading strategy.
Partytown cannot be tested in Cypress, so we're using Playwright instead.
I attempted to point Playwright to the Chrome executable in our test Docker image via the
PLAYWRIGHT_BROWSERS_PATHenv var but it looks like Playwright wants it in a particular directory, not just any directory.For now we install the Chromium executable Playwright wants in a post install script in the prod/develop e2e tests. A better solution probably looks something like creating our own Docker image from the one we already use and add a command to put the Chrome executable in a place Playwright can access. Did not pursue this since we may move the tests back to Cypress if we can get Partytown working in it.
Documentation
N/A
Related Issues
[sc-50697]