feat(gatsby-script): Script component duplicate script warning #35610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test(gatsby-script): e2e test scaffolding * test(gatsby-script): Test pre-hydrate strategy * test(gatsby-script): Refactor resource record command * test(gatsby-script): Test post-hydrate strategy * test(gatsby-script): Test idle strategy * test(gatsby-script): Update readme, npm scripts * test(gatsby-script): Remove unnecessary dev Cypress config * test(gatsby-script): DRY middleware intercepts * chore(gatsby-script): e2e circle ci config * chore(gatsby-script): Add e2e to circle ci jobs * chore(gatsby-script): Use published package so e2e tests can resolve it * test(gatsby-script): Add missing network waits to e2e tests
* feat(gatsby-script): Implement inline scripts * test(gatsby-script): Inline scripts unit tests * test(gatsby-script): Set up for e2e tests * test(gatsby-script): Display scripts with sources strategy * test(gatsby-script): dangerouslySetInnerHTML e2e tests * test(gatsby-script): Template literals e2e tests * chore(gatsby-script): Update package readme * chore(gatsby-script): Install latest canary to run in CI * chore(gatsby-script): Try waitForRouteChange to fix inconsistent Cypress network waits * chore(gatsby-script): Try delaying responses so Cypress has time to set up network waits * chore(gatsby-script): Try increasing network response delay even further * chore(gatsby-script): Remove unreliable Cypress network waits entirely
* feat(gatsby-script): Normal attribute implementation * chore(gatsby-script): Bump default command timeout
* feat(gatsy-script): Initial on load callback implementation * test(gatsby-script): Refactor e2e test structure * refactor(gatsby-script): Fix eslint, ts errors * feat(gatsby-script): Handle edge cases from Gatsby link navigation * test(gatsby-script): Adjust e2e tests so they run successfully again * feat(gatsby-script): On load callback e2e tests * test(gatsby-script): Scripts with sources navigation e2e tests * test(gatsby-script): Inline scripts navigation e2e tests * test(gatsby-script): Adjust e2e tests, add comment on edge case * test(gatsby-script): Fix unit tests
* feat(gatsby-script): On error callback * test(gatsby-script): Update on error callback e2e test logic * chore(gatsby-script): Skip inline scripts gatsby link nav test
* feat(gatsby-script): Partytown internal plugin * feat(gatsby-script): Collect forward props * chore(gatsby-script): Update e2e test to import from gatsby core * chore(gatsby-script): Remove alpha version in core package json * chore(gatsby-script): Define latest gatsby-script in package.json instead * chore(gatsby-script): Lock gatsby-script dep to specific version * refactor(gatsby-script): Do not pass collected scripts to avoid re-renders in SSR * feat(gatsby-script): Collect scripts per page * chore(gatsby-script): Bump alpha * feat(gatsby-script): Proxy Partytown src urls * chore(gatsby-script): Bump alpha * chore(gatsby-script): Test redirects * feat(gatsby-script): Conditionally inject Partytown snippet * feat(gatsby-script): Gatsby serve support * chore(gatsby-script): Remove test redirect
gatsbot
bot
added
the
status: triage needed
marvinjude
force-pushed
the
script-component-same-script-warning
branch
from
6708675 to
b5ef811
Compare
marvinjude
force-pushed
the
script-component-same-script-warning
branch
from
6c23fd9 to
9200820
Compare
* test(gatsby-script): e2e off-main-thread develop runtime * Test in CI * Production runtime * Update load plugins snapshots again * Post install Chromium for Playwright * Fix tests
* add shim and test * add develop and prod run time e2e tests * review updates * Fix imports * Fix prod runtime imports * Namespace tests Co-authored-by: tyhopp <[email protected]>
…cripts (#35692) * feat(gatsby-script): Apply crossorigin anonymous on off-main-thread scripts * Fix offline test flake
tyhopp
force-pushed
the
script-component-same-script-warning
branch
from
9200820 to
55d5650
Compare
|
Closing this to avoid a nasty rebase and use #35708 as a foundation for tests. Will mark Jude as a co-author for warning functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show warning when the same script is loaded with different strategy
Related Issues
[sc-48844]