-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-script): On load callback, cache #35464
Merged
tyhopp
merged 10 commits into
feat-script-component
from
feat-script-component-on-load-callback
Apr 21, 2022
Merged
feat(gatsby-script): On load callback, cache #35464
tyhopp
merged 10 commits into
feat-script-component
from
feat-script-component-on-load-callback
Apr 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Apr 21, 2022
tyhopp
added
topic: performance
Related to runtime & build performance
type: feature or enhancement
Issue that is not a bug and requests the addition of a new feature or enhancement.
topic: frontend
Relates to frontend issues (e.g. reach/router, gatsby-link, page-loading, asset-loading, navigation)
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Apr 21, 2022
12 tasks
There are a few broken e2e tests still in the gatsby script suite, will merge this first so it's not blocking and we can address later |
tyhopp
added a commit
that referenced
this pull request
May 9, 2022
* feat(gatsy-script): Initial on load callback implementation * test(gatsby-script): Refactor e2e test structure * refactor(gatsby-script): Fix eslint, ts errors * feat(gatsby-script): Handle edge cases from Gatsby link navigation * test(gatsby-script): Adjust e2e tests so they run successfully again * feat(gatsby-script): On load callback e2e tests * test(gatsby-script): Scripts with sources navigation e2e tests * test(gatsby-script): Inline scripts navigation e2e tests * test(gatsby-script): Adjust e2e tests, add comment on edge case * test(gatsby-script): Fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: frontend
Relates to frontend issues (e.g. reach/router, gatsby-link, page-loading, asset-loading, navigation)
topic: performance
Related to runtime & build performance
type: feature or enhancement
Issue that is not a bug and requests the addition of a new feature or enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the ability to use an
onLoad
callback for scripts with sources. Usage looks like:Limitations
The
onLoad
callback works only for scripts with sources using thepost-hydrate
oridle
strategies. It does not work with inline scripts.It also includes two other things:
Documentation
To be done in later PR(s).
Related Issues
[sc-48841]
[sc-49445]