perf(gatsby): reuse rootNode & trackedRootNodes caches across instances of graphqlRunner #33695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walking nodes to track inline objects is very expensive. Caching this across instances of the graphql query sped up subsequent queries by ~10-15% (depending on complexity of nodes).
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
topic: performance
KyleAMathews
changed the title
KyleAMathews
changed the title
KyleAMathews
changed the title
KyleAMathews
changed the title
|
Is it possible to have a look at failing tests? 🙏 |
|
|
||
| this._rootNodeMap = _rootNodeMap | ||
| this._trackedRootNodes = _trackedRootNodes | ||
| this._rootNodeMap = _rootNodeMap || new WeakMap() |
There was a problem hiding this comment.
the constructor is also called from /gatsby/packages/gatsby/src/schema/context.ts and the cache is passed there so that's why of the tests are failing. Not sure if it is ok to just create new WeakMap/WeakSet if they are not passed or the global cache can be share between the graphql-runner and the context
There was a problem hiding this comment.
Oh interesting. It seems generally a localNodeModal is passed in there (and perhaps always except for tests?) but yeah, this is a good fallback.
pieh
approved these changes
Jan 11, 2022
pieh
changed the title
moonmeister
added a commit
to moonmeister/gatsby
that referenced
this pull request
Jan 11, 2022
* master: (24 commits) chore(docs): Release Notes v4.5 (gatsbyjs#34425) chore(docs): Update quick-start guide (gatsbyjs#34445) chore(docs) : Typo fix GatbsyImage -> GatsbyImage (gatsbyjs#34439) perf(gatsby): reuse rootNode & trackedRootNodes caches across instances of graphqlRunner (gatsbyjs#33695) Update media-item-processing.md (gatsbyjs#34434) chore(docs): Update localization doc (gatsbyjs#34429) test(ssr): Fix flakes (gatsbyjs#34443) chore(release): Publish next Revert "docs: Match egghead.io video instructions (gatsbyjs#34315)" (gatsbyjs#34384) fix(gatsby-plugin-manifest): generate icons sequentially (gatsbyjs#34331) Fix misspelling of "precedence" in log message (gatsbyjs#34428) chore(docs): Adjust doc mentions of gatsby-plugin-create-client-paths (gatsbyjs#34424) chore(docs): Update static-folder doc (gatsbyjs#34392) Upgrade to strip-ansi ^6.0.1 (gatsbyjs#34383) chore(gatsby-plugin-create-client-paths): Update client paths plugin readme with migration info (gatsbyjs#34423) chore: Remove deprecated client paths plugin references (gatsbyjs#34422) chore(docs): Old occurrences of gatbyjs.org (gatsbyjs#34402) Update plugins.md to have correct URL for gatsby-plugin-segment-js (gatsbyjs#34397) chore(gatsby): Give option to ignore output from workers and silence validate-engines (gatsbyjs#34416) chore(release): Publish next pre-minor ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walking nodes to track inline objects is very expensive. Caching this across
instances of the graphql query sped up subsequent queries by ~10-15% (depending on complexity of nodes).
[sc-41666]