Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): display message about unfit flags found in config #32394

Merged
merged 4 commits into from
Jul 19, 2021

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Jul 16, 2021

Description

There are situations when some feature flag is set in the config but it is not available in a given environment. For example: LMDB_STORE is only available with Node 14.10+ but if you set it in gatsby-config.js and try running a build with Node 12 - it will silently ignore the flag and run with the in-memory store. Which may lead to confusion.

This PR adds a warning to notify you when some flag is set but has no effect. Here is how it looks in CLI output now:

image

[ch32258]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 16, 2021
@vladar vladar added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 16, 2021
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants