Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): Add webpack fs caching for development flag #32264

Merged
merged 10 commits into from
Jul 15, 2021
Merged

feat(gatsby): Add webpack fs caching for development flag #32264

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b177634
feat(gatsby): Enable webpack fs caching for development behind flag w…
KyleAMathews Jul 6, 2021
80b105b
Merge remote-tracking branch 'upstream/master' into dev-webpack-cache
Jul 7, 2021
deb87d2
Merge remote-tracking branch 'upstream/master' into dev-webpack-cache
Jul 10, 2021
da61ca5
Merge remote-tracking branch 'upstream/master' into dev-webpack-cache
Jul 13, 2021
8312533
Restore caching build stages
KyleAMathews Jul 13, 2021
74f092c
Update flags.ts
LekoArts Jul 15, 2021
1df337a
Update flags.ts
LekoArts Jul 15, 2021
e70547d
chore: format
Jul 15, 2021
dfd5abc
Update flags.ts
LekoArts Jul 15, 2021
4343c6e
Update flags.ts
LekoArts Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/gatsby/src/utils/flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,22 @@ const activeFlags: Array<IFlag> = [
}
},
},
{
name: `DEV_WEBPACK_CACHE`,
env: `GATSBY_EXPERIMENTAL_DEV_WEBPACK_CACHE`,
command: `develop`,
telemetryId: `DevWebackCache`,
experimental: false,
description: `Enable webpack's filesystem caching during development. Speeds up the start of the development server.`,
// umbrellaIssue: `https://gatsby.dev/dev-ssr-feedback`,
testFitness: (): fitnessEnum => {
if (sampleSiteForExperiment(`DEV_WEBPACK_CACHE`, 20)) {
return `OPT_IN`
} else {
return true
}
},
},
{
name: `QUERY_ON_DEMAND`,
env: `GATSBY_EXPERIMENTAL_QUERY_ON_DEMAND`,
Expand Down
4 changes: 2 additions & 2 deletions packages/gatsby/src/utils/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,8 +783,8 @@ module.exports = async (
}

if (
process.env.GATSBY_EXPERIMENTAL_PRESERVE_WEBPACK_CACHE &&
(stage === `build-javascript` || stage === `build-html`)
process.env.GATSBY_EXPERIMENTAL_DEV_WEBPACK_CACHE &&
(stage === `develop` || stage === `develop-html`)
KyleAMathews marked this conversation as resolved.
Show resolved Hide resolved
) {
const cacheLocation = path.join(
program.directory,
Expand Down