Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Migrate schema-composer.js to TS #31998

Merged
merged 1 commit into from
Jun 29, 2021
Merged

chore(gatsby): Migrate schema-composer.js to TS #31998

merged 1 commit into from
Jun 29, 2021

Conversation

alisson-suzigan
Copy link
Contributor

@alisson-suzigan alisson-suzigan commented Jun 20, 2021 •
edited
Loading

Description

Convert JS files to TS:

  • schema/schema-composer.js

Related Issues:

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 20, 2021
@alisson-suzigan alisson-suzigan mentioned this pull request Jun 20, 2021
Closed
@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 21, 2021
@LekoArts LekoArts requested a review from vladar June 21, 2021 06:20
@alisson-suzigan
Copy link
Contributor Author

@vladar , could you validate the PR?

vladar
vladar approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 29, 2021
@gatsbybot gatsbybot merged commit 8837033 into gatsbyjs:master Jun 29, 2021
This was referenced Jul 28, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alisson-suzigan @vladar @LekoArts @gatsbybot