Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(functions): added functions examples to examples folder. #31806

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

jsumnersmith
Copy link
Contributor

Description

Adding the functions examples that were originally shared with a separate repo into the main examples folder.

Documentation

Functions are already documented here (though we will remove the beta flag shortly).

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 7, 2021
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@sidharthachatterjee
Copy link
Contributor

@jsumnersmith We have some linting issues, it appears

@LekoArts LekoArts added topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 7, 2021
@jsumnersmith
Copy link
Contributor Author

Will lint and fix locally!

@sidharthachatterjee sidharthachatterjee self-requested a review June 7, 2021 13:15
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship!

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jun 7, 2021
@gatsbybot gatsbybot merged commit ce8e39d into master Jun 7, 2021
@gatsbybot gatsbybot deleted the chore/add-functions-examples branch June 7, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants