chore(gatsby): migrate pageData reducer to TypeScript #23738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
type: TypeScript migration
and removed
status: triage needed
|
Could we also adjust gatsby/packages/gatsby/src/redux/types.ts Line 206 in 87eb2a5 any?
|
pieh
reviewed
May 4, 2020
pieh
requested changes
May 4, 2020
There was a problem hiding this comment.
#23738 (comment) (so the shape of reducer state is actually typed)
- some adjustments needed for
ISetPageDataActiontype
taejs
force-pushed
the
ts-migration/page-data-reducer
branch
from
6d0a410
to
61b4c87
Compare
…/page-data-reducer � Conflicts: � packages/gatsby/src/redux/reducers/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrate pageData reducer to TypeScript
Related Issues
Related to #21995