chore(gatsby): migrate schema reducer to TypeScript #23591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blainekasten
previously requested changes
Apr 29, 2020
This commit implements the migration of the schema reducer to TypeScript by adding the SET_SCHEMA action to the ActionsUnion and by adding the basic types from the IGatsbyState.
hiwelo
force-pushed
the
ts-migration/reducer-schema
branch
from
b8e03b7
to
368db0a
Compare
pieh
approved these changes
May 5, 2020
pieh
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit implements the migration of the schema reducer to TypeScript by adding the
SET_SCHEMAaction to theActionsUnionand by adding the basic types from theIGatsbyStateinterface.(this new PR is following the issue existing in #23476 — the deletion of my fork messed up with the PR, so here's the latest version. Thanks @LekoArts for spotting the issue)
Related Issues
Related to #21995