Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): fix dirty check for inference metadata with related nodes #23472

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Apr 25, 2020

Description

We've caught a small bug while converting inference metadata to Typescript in #23539
It affects dirty checking of the schema when a referenced node changes (when using ___NODE convention)

Before this PR changes to referenced nodes are not detected, after this PR those changes are detected by Gatsby (and schema is rebuilt if actually dirty)

Related Issues

#23264
#23389

@vladar vladar marked this pull request as ready for review April 27, 2020 19:38
@vladar vladar requested a review from a team as a code owner April 27, 2020 19:38
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants