Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Convert query-runner to typescript #22427

Merged
merged 15 commits into from
May 14, 2020
Merged

chore(gatsby): Convert query-runner to typescript #22427

merged 15 commits into from
May 14, 2020
+104 −45

Conversation

mottox2
Copy link
Contributor

@mottox2 mottox2 commented Mar 20, 2020

Description

I converted query/query-runner to typescript

Related Issues

Related to #21995

@mottox2 mottox2 requested a review from a team as a code owner March 20, 2020 06:44
@mottox2 mottox2 changed the title chore(gatsby): Convert query-runner to typescript [WIP] chore(gatsby): Convert query-runner to typescript Mar 20, 2020
@mottox2 mottox2 changed the title [WIP] chore(gatsby): Convert query-runner to typescript chore(gatsby): Convert query-runner to typescript Mar 20, 2020
@blainekasten blainekasten mentioned this pull request Mar 24, 2020
Closed
@dshubhadeep
Copy link

Any updates on this ?
It would be helpful if this is merged so that I can start working on queue.js

@blainekasten
Copy link
Contributor

@dshubhadeep working on it

blainekasten
blainekasten previously approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label May 13, 2020
@gatsbybot gatsbybot merged commit 67fb15b into gatsbyjs:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mottox2 @dshubhadeep @blainekasten @MichaelDeBoey @gatsbybot