-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): migrate messages to typescript #22084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cola119
commented
Mar 9, 2020
packages/gatsby-cli/src/reporter/loggers/ink/components/messages.tsx
Outdated
Show resolved
Hide resolved
packages/gatsby-cli/src/reporter/loggers/ink/components/messages.tsx
Outdated
Show resolved
Hide resolved
blainekasten
reviewed
Mar 9, 2020
MichaelDeBoey
suggested changes
Mar 9, 2020
packages/gatsby-cli/src/reporter/loggers/ink/components/messages.tsx
Outdated
Show resolved
Hide resolved
packages/gatsby-cli/src/reporter/loggers/ink/components/messages.tsx
Outdated
Show resolved
Hide resolved
packages/gatsby-cli/src/reporter/loggers/ink/components/messages.tsx
Outdated
Show resolved
Hide resolved
…es.tsx Co-Authored-By: Michaël De Boey <[email protected]>
…es.tsx Co-Authored-By: Michaël De Boey <[email protected]>
…es.tsx Co-Authored-By: Michaël De Boey <[email protected]>
blainekasten
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, let's merge it!
Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜
This was referenced May 16, 2022
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrated messages component in gatsby-cli to typescript.
Documentation
Related Issues
#21995