Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(babel-preset-gatsby-package): Convert TS #22039

Conversation

MichaelDeBoey
Copy link
Contributor

Description

Convert babel-preset-gatsby-package to TS

Related Issues

Related to #21995

@blainekasten
Copy link
Contributor

This is great! However, I think that the resolver.js needs to stay, it's sort of a set up to let the jest tests mock the require.resolve function. I suspect thats why tests are failing. Revert that and I think this will pass and we can merge!

@MichaelDeBoey
Copy link
Contributor Author

@blainekasten I've done this, because we do this in other places too

const resolve = m => require.resolve(m)

const resolve = m => require.resolve(m)

@blainekasten
Copy link
Contributor

@MichaelDeBoey I understand that, but the reason the tests are failing is because of this change. This was intentionally set up so we could mock require.resolve and have stable tests. So if you revert it, tests will pass and then I can merge it!

@MichaelDeBoey MichaelDeBoey force-pushed the typescript/babel-preset-gatsby-package branch from df53563 to 6898c18 Compare March 9, 2020 21:16
@MichaelDeBoey MichaelDeBoey force-pushed the typescript/babel-preset-gatsby-package branch from 6898c18 to e31f52e Compare March 9, 2020 21:18
@pieh
Copy link
Contributor

pieh commented Mar 10, 2020

I'm not so sure about converting this package? This package doesn't have any package build setup - there is nothing in here to go from TS to JS - and we would have to have different setup, because this is babel-preset-gatsby-package so it can't use same preset to build itself I feel like?

@blainekasten
Copy link
Contributor

@pieh good point. This package benefits relatively little from TS, and we would need to change the infra on this package to work. @MichaelDeBoey thank you so much for your work on this, and sorry it was on lost effort. We're going to close this and remove the package from the list of qualified transitions.

Again, thank you so much and I hope you can keep involved with the transition. You've been extremely responsive and helpful! 🎉

@MichaelDeBoey MichaelDeBoey deleted the typescript/babel-preset-gatsby-package branch April 22, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants