-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(babel-preset-gatsby-package): Convert TS #22039
chore(babel-preset-gatsby-package): Convert TS #22039
Conversation
This is great! However, I think that the resolver.js needs to stay, it's sort of a set up to let the jest tests mock the require.resolve function. I suspect thats why tests are failing. Revert that and I think this will pass and we can merge! |
@blainekasten I've done this, because we do this in other places too
|
@MichaelDeBoey I understand that, but the reason the tests are failing is because of this change. This was intentionally set up so we could mock require.resolve and have stable tests. So if you revert it, tests will pass and then I can merge it! |
df53563
to
6898c18
Compare
6898c18
to
e31f52e
Compare
I'm not so sure about converting this package? This package doesn't have any package build setup - there is nothing in here to go from TS to JS - and we would have to have different setup, because this is |
@pieh good point. This package benefits relatively little from TS, and we would need to change the infra on this package to work. @MichaelDeBoey thank you so much for your work on this, and sorry it was on lost effort. We're going to close this and remove the package from the list of qualified transitions. Again, thank you so much and I hope you can keep involved with the transition. You've been extremely responsive and helpful! 🎉 |
Description
Convert
babel-preset-gatsby-package
to TSRelated Issues
Related to #21995