chore(gastby-transformer-sqip): Use createContentDigest helper #18534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the plugin to use the help instead of manually handling the crypto work.
The `await` keyword was causing Jest to issue a warning because `describe` functions shouldn't be returning Promises.
…-sqip-createContentDigest
pieh
approved these changes
Oct 14, 2019
pieh
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the plugin to use the helper instead of manually handling the crypto work. While I was running the unit tests I noticed there was a warning being thrown by Jest about the
describeblock returning a Promise. I went ahead and removed theawaitkeyword. If necessary I can split that commit off into it's own PR, just let me know.Related Issues
Related to #8805