Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: graphql api page and other incremental improvements #17516

Merged
merged 22 commits into from
Sep 24, 2019

Conversation

gillkyle
Copy link
Contributor

@gillkyle gillkyle commented Sep 9, 2019

Description

Initial improvements to the Gatsby GraphQL API's, mostly around querying and using image fragments.

The changes in this PR are to help make GraphQL content easier for people new to Gatsby to grok and discover. Some docs had names that weren't explicit as to their purpose and made finding the page with relevant information difficult. An example of this was the "GraphQL Reference" and "Introducing GraphiQL" docs which were updated to "GraphQL Query Options Reference" and "Running Queries with GraphiQL" respectively.

A GraphQL API page was added to the Gatsby API section to serve as a holistic foundation for GraphQL uses in Gatsby like sourcing data, querying data, using fragments, and linking to guides on advanced uses like schema customization. This page still has plenty to add to it, particularly with querying options like sort, filter, etc as outlined in #15231

GraphQL API page

localhost_8000_docs_graphql-api_

This doesn't resolve all updates to the GraphQL workflow but is a start 👍

Related Issues

Partially addresses points in:
#16981
#15231

@gillkyle gillkyle requested review from a team as code owners September 9, 2019 19:38
@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Sep 16, 2019
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller comments :)

docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Show resolved Hide resolved
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR! I left a ton of suggestions on this one, so thanks in advance for going through them. Let me know if you have any questions! I'm also planning to add some info to the contributing docs on API docs vs. conceptual and reference guides.

docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is amazing! I left a few small suggestions. It's super close. Thank you so much for your work on this, @gillkyle!

docs/docs/graphql-concepts.md Outdated Show resolved Hide resolved
docs/docs/graphql-api.md Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
@gillkyle gillkyle added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Sep 20, 2019
Co-Authored-By: Marcy Sutton <[email protected]>
@gillkyle gillkyle added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response labels Sep 24, 2019
@gatsbybot gatsbybot merged commit c175f9e into master Sep 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the graphql-workflow branch September 24, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants