Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-plugin-guess-js): Update Readme on how to configure usage with CI #15774

Merged
merged 3 commits into from
Jul 23, 2019

Conversation

Tian94-zz
Copy link

Adding documentation on how to configure the plugin to be used within a CI pipeline.

Description

Related Issues

Adding documentation on how to configure the plugin to be used within a CI pipeline.
@Tian94-zz Tian94-zz requested a review from a team as a code owner July 16, 2019 05:33
@lannonbr lannonbr changed the title Update README.MD chore(gatsby-plugin-guess-js): Update Readme on how to configure usage with CI Jul 16, 2019
wardpeet
wardpeet previously approved these changes Jul 23, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks for updating!

@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 23, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we have a flaky test. I'll be merging with my super powers.

Thank you for updating our docs! <3

@wardpeet wardpeet merged commit 8f4d3f3 into gatsbyjs:master Jul 23, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 23, 2019

Holy buckets, @Tian94 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants