Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog excerpt formatting issue #8964

Closed
mingaldrichgan opened this issue Oct 9, 2018 · 3 comments
Closed

Blog excerpt formatting issue #8964

mingaldrichgan opened this issue Oct 9, 2018 · 3 comments
Assignees
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: bug An issue or pull request relating to a bug in Gatsby

Comments

@mingaldrichgan
Copy link
Contributor

Steps to reproduce

Visit https://www.gatsbyjs.org/blog/ (or scroll to the bottom of https://www.gatsbyjs.org under Latest from the Gatsby blog) and look at excerpt for Delivering Modern Website Experiences: The Journey to a Content Mesh from October 4 (currently the second result).

Actual result

The CMS was born to make content sites possible . Now, it’s being reimagined to make them incredible . In the early 2000s, publishing on…

Note the extra space after "possible" and "incredible", before each period. Inspecting the DOM, I see extra spaces on both sides of those words:

The CMS was born to make content sites  possible .
Now, it’s being reimagined to make them  incredible .
In the early 2000s, publishing on…

Looking at the Markdown source, it looks like underscores are getting replaced by spaces while generating the excerpt.

Expected result

This depends on whether the excerpt is intended to be plaintext or formatted.

If plaintext, I would expect the underscores to get stripped out entirely, leaving no space before each period.

If formatted, I would expect the words possible and incredible to be italicized.

Comments

I assume this bug (if it is a bug) lies in gatsby-transformer-remark but I'm hoping that someone more familiar with the codebase will be able to clarify the expected behavior and where that behavior is implemented. I wouldn't mind picking this up for Hacktoberfest… 👻

@mingaldrichgan mingaldrichgan self-assigned this Oct 9, 2018
@pieh
Copy link
Contributor

pieh commented Oct 9, 2018

I think it should be formatted - there is open issue for it #4459 and PR for it #5586 - PR is abandoned now, so you can use that as starting point. I'll go to PR to document what need to be done there

@kakadiadarpan kakadiadarpan added the type: bug An issue or pull request relating to a bug in Gatsby label Oct 10, 2018
@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 21, 2019
@gatsbot
Copy link

gatsbot bot commented Jan 21, 2019

Old issues will be closed after 30 days of inactivity. This issue has been quiet for 20 days and is being marked as stale. Reply here or add the label "not stale" to keep this issue open!

@gatsbot
Copy link

gatsbot bot commented Feb 1, 2019

Hey again!

It’s been 30 since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

3 participants